Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the getter parsing to specifically track unsafe getters to ensure they are never emitted.
This happens for example in pg with:
where the internal
defineProperty
with a value definition to do the replacement after the getter has been called is seen as a safe getter so the export is emitted.Instead we define an unsafe getter to mean any getter definition which does not fit one of the safe determined patterns. Once there is an unsafe definition for a given export name, it will never be emitted as an export even if there is a subsequent safe emission pattern.