deps: upgrade to cjs-module-lexer@1.0.0 #35928
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to cjs-module-lexer@1.0.0, with some final getter refinements to fix #35859.
To explain the getter handling story here:
Object.defineProperty
once called to set a value property, which was then being detected as one of these safe properties.Thus this update includes the fix at nodejs/cjs-module-lexer#29 which adds unsafe getter tracking to specifically mark unsafe getters and never emit them even if they later have safe getter forms.
I've verified this fixes the test case from #35859.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes