-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rules: check spaces in commit title #35
Conversation
targos
commented
Nov 18, 2018
- Do not allow consecutive spaces
- Require a space after the subsystems
- Do not allow consecutive spaces - Require a space after the subsystems
Can I merge this? Who is responsible for the module? |
@targos Since you're a member of @nodejs/automation-collaborators, you are 👍 to merge this. (You can see the teams listed under Settings -> Collaborators & teams.) Someone will still need to tag and publish a new version of the package for this to take effect. Package maintainers according to https://www.npmjs.com/package/core-validate-commit are Evan, Joyee, and "Node.js Foundation". Not sure who has publishing rights via that last account, but if you know, please tell me! |
That's an account managed by the Build WG:
|
I guess with the current state it's probably..me? But I would be very happy to see more people getting access to this repo and the npm module since I am also a bit overloaded and don't always see the notifications here... Judging by the recent activity I think we can add @targos @Trott and @richardlau to the npm collaborators team, if they are willing to be added. (@richardlau would you be interested in getting write access to this repo? Either as a collaborator of this repo, or just as a member of @nodejs/automation-collaborators , I guess for the latter we can open an issue to https://github.com/nodejs/automation first) cc @evanlucas (not sure if you are still on leave, sorry for the noise) |
I would be happy to have access to npm publication rights |
Yes, I'd be interested. |
I have added @targos and @richardlau as npm collaborators and added @richardlau as a collaborator in this repo (@targos should have access through TSC / automation-collaborators already) |
Do we have a special process to publish packages on npm? |
@targos That's what I do, yes, I guess you can also updates the release notes on GitHub but I don't know who actually reads those.. |
This reverts commit 7be8a42.