Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: check spaces in commit title #35

Merged
merged 1 commit into from
Nov 19, 2018
Merged

rules: check spaces in commit title #35

merged 1 commit into from
Nov 19, 2018

Conversation

targos
Copy link
Member

@targos targos commented Nov 18, 2018

  • Do not allow consecutive spaces
  • Require a space after the subsystems

- Do not allow consecutive spaces
- Require a space after the subsystems
@targos
Copy link
Member Author

targos commented Nov 18, 2018

Can I merge this? Who is responsible for the module?

@Trott
Copy link
Member

Trott commented Nov 19, 2018

Can I merge this? Who is responsible for the module?

@targos Since you're a member of @nodejs/automation-collaborators, you are 👍 to merge this. (You can see the teams listed under Settings -> Collaborators & teams.)

Someone will still need to tag and publish a new version of the package for this to take effect. Package maintainers according to https://www.npmjs.com/package/core-validate-commit are Evan, Joyee, and "Node.js Foundation". Not sure who has publishing rights via that last account, but if you know, please tell me!

@richardlau
Copy link
Member

"Node.js Foundation". Not sure who has publishing rights via that last account, but if you know, please tell me!

That's an account managed by the Build WG:
https://github.com/nodejs/build/blob/master/doc/access.md#npm-management

  • The nodejs-foundation npm user, which is managed by the Build WG, is an administrator on all Foundation npm packages. It is the means to add or remove other module collaborators, and shouldn't be used to publish releases.

@joyeecheung joyeecheung merged commit d280cd9 into master Nov 19, 2018
@joyeecheung
Copy link
Member

Can I merge this? Who is responsible for the module?

I guess with the current state it's probably..me? But I would be very happy to see more people getting access to this repo and the npm module since I am also a bit overloaded and don't always see the notifications here...

Judging by the recent activity I think we can add @targos @Trott and @richardlau to the npm collaborators team, if they are willing to be added.

(@richardlau would you be interested in getting write access to this repo? Either as a collaborator of this repo, or just as a member of @nodejs/automation-collaborators , I guess for the latter we can open an issue to https://github.com/nodejs/automation first)

cc @evanlucas (not sure if you are still on leave, sorry for the noise)

@targos
Copy link
Member Author

targos commented Nov 19, 2018

I would be happy to have access to npm publication rights

@richardlau
Copy link
Member

(@richardlau would you be interested in getting write access to this repo? Either as a collaborator of this repo, or just as a member of @nodejs/automation-collaborators , I guess for the latter we can open an issue to https://github.com/nodejs/automation first)

Yes, I'd be interested.

@targos targos deleted the check-spaces branch November 19, 2018 18:32
@joyeecheung
Copy link
Member

I have added @targos and @richardlau as npm collaborators and added @richardlau as a collaborator in this repo (@targos should have access through TSC / automation-collaborators already)

@targos
Copy link
Member Author

targos commented Nov 22, 2018

Do we have a special process to publish packages on npm?
Or is it just npm version whatever && npm publish && git push --follow-tags?

@joyeecheung
Copy link
Member

@targos That's what I do, yes, I guess you can also updates the release notes on GitHub but I don't know who actually reads those..

richardlau pushed a commit to richardlau/core-validate-commit that referenced this pull request Dec 15, 2018
richardlau added a commit to richardlau/core-validate-commit that referenced this pull request Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants