Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add worker to subsystems and add subsystems tests #42

Merged
merged 2 commits into from
Jan 11, 2019
Merged

add worker to subsystems and add subsystems tests #42

merged 2 commits into from
Jan 11, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 24, 2018

No description provided.

joyeecheung
joyeecheung reviewed Dec 25, 2018
View reviewed changes
lib/rules/subsystem.js Outdated Show resolved Hide resolved
@Trott
Copy link
Member Author

Trott commented Jan 11, 2019

There appears to be far more enthusiasm for continuing to use worker as the subsystem rather than switching to worker_threads so I've updated this PR to reflect this. Let's get this approved, landed, and released, so I can land a bunch of worker-related PRs without bypassing the tooling!

mcollina
mcollina approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott changed the title add worker_threads to subsystems and add subsystems tests add worker to subsystems and add subsystems tests Jan 11, 2019
@richardlau richardlau merged commit d2b2295 into nodejs:master Jan 11, 2019
@richardlau
Copy link
Member

I've published v3.8.0 following instructions on #35 (comment).

This is the first time I've done this, so please let me know if I've done anything wrong! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung left review comments

@addaleax addaleax addaleax left review comments

@richardlau richardlau richardlau approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @richardlau @mcollina @addaleax @joyeecheung