Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect authorization prefix for basic auth, and undocumented env var #454

Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix: Incorrect authorization prefix for basic auth, and undocumented env var #454

merged 5 commits into from
Apr 12, 2024

Commits on Apr 12, 2024

  1. basic auth with base64 username:password should be labelled Basic, no… 

    …t Bearer
    @plumpNation
    plumpNation authored and Gavin King committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4b1d2c7 View commit details
    Browse the repository at this point in the history

  2. Fix: either this env var is a typo, or it's undocumented

    Gavin King committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    46f8219 View commit details
    Browse the repository at this point in the history

  3. username and password for basic auth doesn't need 2 code flows

    Gavin King committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a6cfd0f View commit details
    Browse the repository at this point in the history

  4. Invalid usage of OR condition 

    The location of the registry should be validated against the input.origin. With the current code, it simply checks to see if DEFAULT_NPM_REGISTRY_URL exists.

I made the registries into an array to make a regression less likely.
    Gavin King committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c70c546 View commit details
    Browse the repository at this point in the history

  5. Update sources/httpUtils.ts

    @aduh95
    aduh95 authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7e74956 View commit details
    Browse the repository at this point in the history