fix: Incorrect authorization prefix for basic auth, and undocumented env var #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plumpNation
force-pushed
the
incorrect-authorization-type
branch
from
780acec
to
11419a2
Compare
plumpNation
changed the title
plumpNation
force-pushed
the
incorrect-authorization-type
branch
from
0cabeae
to
78ae0ed
Compare
aduh95
reviewed
Apr 12, 2024
plumpNation
force-pushed
the
incorrect-authorization-type
branch
from
78ae0ed
to
a6cfd0f
Compare
The location of the registry should be validated against the input.origin. With the current code, it simply checks to see if DEFAULT_NPM_REGISTRY_URL exists. I made the registries into an array to make a regression less likely.
aduh95
reviewed
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes auth type header strings to use
Basicprefix for base64 encoded username:password.In addition, it seems like an undocumented env var
COREPACK_NPM_USERis being used in tests, meaning that this value will beundefinedand the user will always get a 401 as the documented env var isCOREPACK_NPM_USERNAME.This bit me when I was using a test to help debug why my COREPACK_NPM_REGISTRY was being ignored when running
yarn --versionin real life.