Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub Status API #15

Merged
merged 1 commit into from
Apr 10, 2016
Merged

Use GitHub Status API #15

merged 1 commit into from
Apr 10, 2016

Conversation

Fishrock123
Copy link
Contributor

Here's a test of a success status, and a failure status.

cc @williamkapke & @phillipj

Fishrock123
Fishrock123 reviewed Apr 8, 2016
View reviewed changes
lib/pollTravis.js
repo: options.repoName,
sha: options.lastSha,
target_url: `https://travis-ci.org/${options.owner}/${options.repoName}/builds/${travisId}`,
context: "Travis CI via nodejs-github-bot",

This comment was marked as off-topic.

Sign in to view

@Fishrock123
Copy link
Contributor Author

Fixes: #14

@Fishrock123 Fishrock123 force-pushed the github-status-api branch 2 times, most recently from 7be5ef6 to dd117b5 Compare April 8, 2016 22:59
@Fishrock123
Copy link
Contributor Author

rebased

@williamkapke
Copy link
Contributor

LGTM

@phillipj
Copy link
Member

phillipj commented Apr 9, 2016

You mentioned on IRC that we should be polling SHA for all repos. Any reason you haven't deleted pollByPrThenComment()?

IIRC this means we would do status updates for readable-stream, but still do comments on nodejs.org and citgm.

@phillipj
Copy link
Member

phillipj commented Apr 9, 2016

Have you tested updates on PRs and how that affects previously set statuses? Could we end up with misleading success status on a PR if the first build succeeded, but new commits/pushed rebase results in brokens builds?

@Fishrock123
Copy link
Contributor Author

@phillipj I left that because I wasn't sure if it was still necessary.

Afaik statuses tie to commits, so if the commits are updated GitHub automatically resets it.

@Fishrock123
Copy link
Contributor Author

I'll give it a test when I get home later though.

phillipj
phillipj reviewed Apr 9, 2016
View reviewed changes
lib/pollTravis.js
} else if (~['created', 'started'].indexOf(lastState)) {
console.log(`* ${prInfo} "${lastState}" build found, will do check #${checkNumber + 1} in 30 seconds`)
if (checkNumber === 1) {

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@Fishrock123
Copy link
Contributor Author

Hmmm, looks like this no-longer works after being rebased on #8. Investigating.

@Fishrock123
Copy link
Contributor Author

Got it working. My bad.

Looks like this doesn't actually handle PR updates, working on it. (Example: TestOrgPleaseIgnore/test-github-bot#17)

@Fishrock123
Copy link
Contributor Author

Updated, now works for PR updates: TestOrgPleaseIgnore/test-github-bot#17

@Fishrock123 Fishrock123 merged commit 8e255d3 into nodejs:master Apr 10, 2016
@Fishrock123
Copy link
Contributor Author

going to open a new PR for some of the other bits

Fishrock123 added a commit to Fishrock123/github-bot that referenced this pull request Apr 10, 2016
@Fishrock123
Remove outdated travis commenting logic
a6c5b36 
Discussion in nodejs#15
@Fishrock123 Fishrock123 mentioned this pull request Apr 10, 2016
Merged
@phillipj phillipj mentioned this pull request Apr 10, 2016
Closed
@Fishrock123 Fishrock123 mentioned this pull request Apr 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fishrock123 @williamkapke @phillipj