emit github events

[williamkapke]

Not tested- but should mostly be correct ;)

EDIT: Testing & working!

I'm using a .env file like discussed in #7 (comment)

You'll probably notice that github-webhook-handler is referencing my fork- hopefully @rvagg will accept my PR and that can be replaced soon. If not, I can do it a uglier way. EDIT: Needed to go a different direction in the end anyhow.

[williamkapke]

This just ran this successfully here: https://github.com/no-duh/nodejs.org/pull/1

Travis updated the PR status also... I'm guessing it is because I gave it permission to and the https://github.com/node/nodejs.org repo doesn't give Travis the permission to..?

I tried to follow along nodejs/nodejs.org#355 but didn't grasp what is going on. I'd like to completely mirror the behavior if I can.

[Fishrock123]

@williamkapke Try doing it in my org, I can set the permissions up.

You need to enable advanced restrictions, try to sync travis, ask for org permission from your own permissions, turn travis on after you've approved it, and then revoke the permission from the org.

[williamkapke]

Ok- as you probably saw, I created the nodejs.org repo there, but then deleted it. I didn't use it because it added everyone as watchers and I wanted to be considerate about not spamming. I'll set it up now that I know it is working and the notifications shouldn't be as bad.

[williamkapke]

@Fishrock123 ok, I guess you'll need to setup Travis. It won't let me do it...

[Fishrock123]

@williamkapke Ok https://travis-ci.org/TestOrgPleaseIgnore/nodejs.org is "semi-on" now.

[phillipj]

@williamkapke merged #12 to get enable the bot on the readable-stream repo, the merge conflict should be trivial to resolve. I renamed pollTravis.pollAndComment() -> pollTravis.pollThenComment().

By rebasing on top of master you'll even get Travis to run this PR ;)

Please confirm this is good to go after the conflict has been resolved, and I'll be more than happy to push it to production.

[Fishrock123]

pollThenComment should probably renamed to pollThenStatus here I guess?

[williamkapke]

Rebased. Tested. Here's the log output...

event@TestOrgPleaseIgnore/nodejs.org: pull_request.opened
Thu, 07 Apr 2016 19:48:28 GMT display_travis_status /TestOrgPleaseIgnore/nodejs.org/pull/2 opened
! TestOrgPleaseIgnore/nodejs.org/#2 Was not able to find matching build, will do check #2 in 30 seconds
* TestOrgPleaseIgnore/nodejs.org/#2 "started" build found, will do check #3 in 30 seconds
* TestOrgPleaseIgnore/nodejs.org/#2 "started" build found, will do check #4 in 30 seconds
* TestOrgPleaseIgnore/nodejs.org/#2 Github comment created
event@TestOrgPleaseIgnore/nodejs.org: issue_comment.created

See:
https://github.com/TestOrgPleaseIgnore/nodejs.org/pull/2

[phillipj]

pollThenComment should probably renamed to pollThenStatus here I guess?

The latter sounds like we're using the Status API, but we're still commenting on PR's here.. Or did I misunderstand?

[Fishrock123]

The status here was emitted by travis itself, right?

[phillipj]

LGTM

Looks like it introduces secrets, so we'll have to update the active PRs before pushing it to prod

[williamkapke]

Ah yes. I added the header validation. So the GITHUB_WEBHOOK_SECRET will need to be added.