Don't post PR comment on errors when triggering Lite-CI #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the bot is does not have permission to trigger Jenkins Lite-CI builds for some reason at the moment, and there's feedback about these error comments not being useful to collaborators anyways, those comments are muted for now. Ideally github-bot maintainers should get notified about these errors, as they're obviously not meant to be raised at all. But using node core collaborators as proxy, manually telling bot maintainers about errors surely isn't idealy either. Refs nodejs#238 Refs nodejs#235 (comment)
|
Taking the liberty of rolling this out as no objections has been made and quite a few has asked for this to happen, in fact no one has said this is actually useful. |
|
Belated LGTM, thanks @phillipj |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the bot does not have permission to trigger Jenkins Lite-CI builds for some reason at the moment, and there's feedback about these error comments not being useful to collaborators anyways, those comments are muted for now.
Ideally github-bot maintainers should get notified about these errors, as they're obviously not meant to be raised at all. But using node core collaborators as proxy, manually telling bot maintainers about errors surely isn't ideal either.
Refs #238
Refs #235 (comment)
/cc @nodejs/github-bot @cjihrig @sam-github