Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't post PR comment on errors when triggering Lite-CI #241

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Don't post PR comment on errors when triggering Lite-CI #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions scripts/trigger-jenkins-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,13 @@ function triggerBuildIfValid (options) {
}

triggerBuild(options, function onBuildTriggered (err, result) {
let body = ''

if (err) {
logger.error(err, 'Error while triggering Jenkins build')
body = 'Sadly, an error occurred when I tried to trigger a build. :('
} else {
const jobUrl = `https://ci.nodejs.org/job/${result.jobName}/${result.jobId}`
logger.info({ jobUrl }, 'Jenkins build started')
body = `Lite-CI: ${jobUrl}`
return logger.error(err, 'Error while triggering Jenkins build')
}

createPrComment(options, body)
const jobUrl = `https://ci.nodejs.org/job/${result.jobName}/${result.jobId}`
logger.info({ jobUrl }, 'Jenkins build started')
createPrComment(options, `Lite-CI: ${jobUrl}`)
})
})
}
Expand Down