Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

[el-translation] Add the greek version of index.md, faq.md and the template links #139

Merged
merged 4 commits into from
Feb 10, 2015
Merged

Conversation

AntouanK
Copy link
Contributor

@AntouanK AntouanK commented Feb 9, 2015

  • commit the index markdown

- commit the index markdown
- Small change on index.md
- add the FAQ page
@AntouanK AntouanK changed the title [el-translation] Add the greek version of index.md and the template links [el-translation] Add the greek version of index.md, faq.md and the template links Feb 9, 2015
- convert english question marks to greek ones
@therebelrobot
Copy link
Contributor

dependent on #119

@AntouanK
Copy link
Contributor Author

AntouanK commented Feb 9, 2015

do we also commit the public/... compiled files?
If not, I think they should be added on .gitignore so only the build process will create them.
No need to keep them in the repo.

@therebelrobot
Copy link
Contributor

We are committing the public/ files for the time being, until we have gulp running on the deploy server. At that point we will remove them and gitignore them. That'll most likely be a website WG task though, so no worries.

@AntouanK
Copy link
Contributor Author

AntouanK commented Feb 9, 2015

cool
could we also add the i18n label on this PR?

@therebelrobot
Copy link
Contributor

+1

@@ -3,10 +3,10 @@
"logo-text":"io.js",
"faq-link":"FAQ",
"es6-link":"ES6",
"api-link":"API Docs",
"api-link":"API",

This comment was marked as off-topic.

This comment was marked as off-topic.

@therebelrobot
Copy link
Contributor

@AntouanK could you get another native speaker to review and +1 this PR? We want to make sure the content is good to roll, but it's all greek to me... hee hee... I'll show myself out.

@AntouanK
Copy link
Contributor Author

@therebelrobot I had the commit link on gitter and asked the other guys to check it out. Got the ok from them and fixed a few things.
If I could some how post the preview on the iojs_el repo, it would nicer so you guys can see the comments and the review.
Let me know what's the process you prefer.

@sirodoht
Copy link

👍 for the translation, answering as a fellow Greek native speaker.

@therebelrobot
Copy link
Contributor

@AntouanK I personally would like to keep the +1's on this, I don't necessarily need to know the specifics of updates needed in each language, so long as more than one pair of eyes are on it. If all we need is a +1, keeping it here in the main website PR is preferable. That's certainly up for discussion, but that's what I'm thinking.

therebelrobot added a commit that referenced this pull request Feb 10, 2015
[el-translation] Add the greek version of index.md, faq.md and the template links
@therebelrobot therebelrobot merged commit 15fa110 into nodejs:build/gulpjs Feb 10, 2015
@therebelrobot
Copy link
Contributor

@AntouanK, will you reopen this PR going into master instead of build/gulpjs? I'll get it in as soon as you open it.

@AntouanK
Copy link
Contributor Author

@therebelrobot Should I also commit the public/ files in that PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants