WIP - Adds build process (Gulp.js-based) #119
Conversation
…rify for gulpfile inclusion
translate styles.css to stylus
…or if Substack merges my commit over there.
|
Agreed that this is not yet ready, but that it provides better transparency on the work we're doing. :) |
|
What are the current blockers? Maybe we can edit the PR description at the top to include a checklist. |
|
The only blocker on this was time. I'm dedicating a good 6-8 hours on this today, and this PR should be ready to merge. |
|
Need any help today @therebelrobot ? Whether with review, testing or breaking off some sub tasks? |
|
@snostorm, I'm almost there currently, the index is compiling fine, as the screenshot above shows. Working on breaking out the faq and es6 pages next, if you want to take one of those, convert the content into markdown and tweak the css, that'd be spectacular. |
Yeah, I guess that may be more of a question for @mikeal or someone on build, doesn't look like it got answered above. |
|
We should probably put a TRANSLATION.md into this PR to ensure that translation groups are following the procedure we need them to. I'll get that worked up right now. |
Also added a TRANSLATION.md file to increase awareness of how to contribute to translation
|
Ok. We should be good to go now. I added index.html, es6.html and faq.html with redirects into /en for now. If we want to use nginx later we can. Also, I added a TRANSLATION.md file to make sure localization groups know how to contribute to the translation of the site. I'm off to dinner for now, but I've got my phone on me, hit me up if something needs changing. |
|
Ack, I forgot to squash the commits. I'll get that in. |
|
Wow. I am royally mucking up this squash. Anyone want to take that? Everything should be ready to go. |
|
I'm terrible at squashing :( @Fishrock123 is awesome at it though. |
|
If i squash this, it will look like me just copying the directory overtop of the current head and commiting it XD |
|
I guess I could try that octopus merge ben told me about.. |
|
Should we ignore all auto build out |
|
Will do the squash and merge tomorrow. |
|
@fengmk2 we're including generated .html files in public right now as our web server requires them for publishing purposes. Later we'll be ignoring this, yes. |
|
As much as we want to rush this in for speed of facilitating our i18n teams, I'd rather hold on this. After further review/testing the main (The slowness was especially noticeable post watch-trigger while having to wait for the files to reload. On my typically zippy machine I could actually see the HTML appearing in files line-by-line.) Anyway, I don't want to block this long. If i18n groups are excited to translate, let's get them forking off of the content directory in this branch for the next 24h or so then do a big PR + merge party after this goes live. |
|
Don't block this on build performance, having something that is kinda slow is better than having nothing :) |
|
Squashed cleanly, how will this interact with the nginx config? Do I need to PR a redirect to /en/ there for now? |
|
Oh, that landed in 2cdc6c4. Fixing up and landing this. |
|
💯 |
|
@snostorm the css tasks run 22 times slower than the template tasks for me. The template build takes half a second, compared to 11 seconds. (Also I dunno why the css build is quite that slow..) |
|
(unless the templates task end isn't actually at the end of the templates build..) |
Uses Markdown and html-template for content templating. PR-URL: nodejs#119 Closes nodejs#119 Closes nodejs#22 See also nodejs#33 See also nodejs#125
For some (easier) transparency in to the progress of this branch I've opened a PR. As of today I assume it is not in a merge-ready state but I did want to get easier access for us to review the ongoing diff and moving towards a merge sooner-than-later.
I don't think we need to get everything perfect early on, just solid/simple enough with a reasonable enough pattern we can build some additional content off of.