Skip to content

Commit

Permalink
src: use new SystemPointerSize constant
Browse files Browse the repository at this point in the history
This alone should fix a lot of issues. It was enough to get a reasonable
stack trace from a Node.js v12.3.0 core dump, ran with
--interpreted-frames-native-stack. For some reason `v8 bt` is not
working when running Node.js in lldb.

PR-URL: #300
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
mmarchini committed Sep 27, 2019
1 parent fb25c91 commit 2c4c99c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/llv8-constants.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ void Module::Assign(SBTarget target, Common* common) {


void Common::Load() {
kPointerSize = 1 << LoadConstant("PointerSizeLog2");
kPointerSize = 1 << LoadConstant("PointerSizeLog2", "SystemPointerSizeLog2");
kVersionMajor = LoadRawConstant("v8::internal::Version::major_");
kVersionMinor = LoadRawConstant("v8::internal::Version::minor_");
kVersionPatch = LoadRawConstant("v8::internal::Version::patch_");
Expand Down

0 comments on commit 2c4c99c

Please sign in to comment.