src: use new SystemPointerSize constant #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This alone should fix a lot of issues. It was enough to get a reasonable stack trace from a Node.js v12.3.0 core dump, ran with --interpreted-frames-native-stack. For some reason `v8 bt` is not working when running Node.js in lldb.
cjihrig
approved these changes
Sep 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
======================================
Coverage 78.6% 78.6%
======================================
Files 33 33
Lines 4225 4225
======================================
Hits 3321 3321
Misses 904 904
Continue to review full report at Codecov.
|
mmarchini
added a commit
that referenced
this pull request
Sep 27, 2019
This alone should fix a lot of issues. It was enough to get a reasonable stack trace from a Node.js v12.3.0 core dump, ran with --interpreted-frames-native-stack. For some reason `v8 bt` is not working when running Node.js in lldb. PR-URL: #300 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 2c4c99c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alone should fix a lot of issues. It was enough to get a reasonable
stack trace from a Node.js v12.3.0 core dump, ran with
--interpreted-frames-native-stack. For some reason
v8 btis notworking when running Node.js in lldb.