Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object::GetPropertyNames() not const #380

Closed
AeromXundes opened this issue Oct 30, 2018 · 1 comment
Closed

Object::GetPropertyNames() not const #380

AeromXundes opened this issue Oct 30, 2018 · 1 comment

Comments

@AeromXundes
Copy link

The method Object::GetPropertyNames() is not declared const.

The method napi_get_property_names() cannot not modify any member fields as the variables _env and _value are passed by value and result is a local variable. Thus, the function should be declared as const.

This will add the ability to declare a const Object and still get the property names associated with the object.
DaAitch added a commit to DaAitch/node-addon-api that referenced this issue Dec 26, 2018
@DaAitch
src: make Object::GetPropertyNames() const
91c25d2 
Closes: nodejs#380
@DaAitch DaAitch mentioned this issue Dec 26, 2018
Closed
@DaAitch
Copy link
Contributor

DaAitch commented Dec 26, 2018

@AeromXundes agree: PR created

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
src: make Object::GetPropertyNames() const
3f4add1 
Fixes: nodejs/node-addon-api#380
PR-URL: nodejs/node-addon-api#415
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
src: make Object::GetPropertyNames() const
5be9fc3 
Fixes: nodejs/node-addon-api#380
PR-URL: nodejs/node-addon-api#415
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
src: make Object::GetPropertyNames() const
224f1c6 
Fixes: nodejs/node-addon-api#380
PR-URL: nodejs/node-addon-api#415
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
src: make Object::GetPropertyNames() const
5609797 
Fixes: nodejs/node-addon-api#380
PR-URL: nodejs/node-addon-api#415
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DaAitch @AeromXundes