Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make Object::GetPropertyNames() const #415

Closed
wants to merge 1 commit into from
Closed

src: make Object::GetPropertyNames() const #415

wants to merge 1 commit into from

Conversation

DaAitch
Copy link
Contributor

@DaAitch DaAitch commented Dec 26, 2018

Closes: #380

mhdawson
mhdawson approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Jan 2, 2019
@DaAitch @mhdawson
src: make Object::GetPropertyNames() const
020ac4a 
Fixes: #380
PR-URL: #415
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member

mhdawson commented Jan 2, 2019

Landed as 020ac4a

@mhdawson mhdawson closed this Jan 2, 2019
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
src: make Object::GetPropertyNames() const
3f4add1 
Fixes: nodejs/node-addon-api#380
PR-URL: nodejs/node-addon-api#415
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
src: make Object::GetPropertyNames() const
5be9fc3 
Fixes: nodejs/node-addon-api#380
PR-URL: nodejs/node-addon-api#415
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
src: make Object::GetPropertyNames() const
224f1c6 
Fixes: nodejs/node-addon-api#380
PR-URL: nodejs/node-addon-api#415
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
src: make Object::GetPropertyNames() const
5609797 
Fixes: nodejs/node-addon-api#380
PR-URL: nodejs/node-addon-api#415
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaAitch @mhdawson @gabrielschulhof