Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: rename N-API with Node-API on comments #952

Closed
NickNaso opened this issue Mar 25, 2021 · 1 comment
Closed

src: rename N-API with Node-API on comments #952

NickNaso opened this issue Mar 25, 2021 · 1 comment

Comments

@NickNaso
Copy link
Member

Refs: nodejs/abi-stable-node#420
It's necessary to rename N-API with Node-API all over the comments in the source code.
@NickNaso NickNaso mentioned this issue Mar 25, 2021
Closed
@NickNaso
Copy link
Member Author

PR: #953

deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this issue Sep 23, 2021
@NickNaso
src: rename N-API with Node-API on comments
5110815 
Also fixed lint errors.

Fixes: nodejs#952
PR-URL: nodejs#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this issue Oct 15, 2021
@NickNaso
src: rename N-API with Node-API on comments
5c5d885 
Also fixed lint errors.

Fixes: nodejs#952
PR-URL: nodejs#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
src: rename N-API with Node-API on comments
662e4f4 
Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
src: rename N-API with Node-API on comments
ce500e6 
Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
src: rename N-API with Node-API on comments
31c9fbf 
Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
src: rename N-API with Node-API on comments
f8294e6 
Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickNaso