Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: rename N-API with Node-API on comments #953

Closed
wants to merge 2 commits into from
Closed

src: rename N-API with Node-API on comments #953

wants to merge 2 commits into from

Conversation

NickNaso
Copy link
Member

Fixes issue #952
In this PR I renamed N-API to Node-API in all the comments in the source code.

@NickNaso NickNaso mentioned this pull request Mar 25, 2021
Closed
legendecas
legendecas approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume most of the unrelated changes are subject to linter complaints?

@NickNaso
Copy link
Member Author

NickNaso commented Mar 26, 2021 •
edited
Loading

LGTM. I assume most of the unrelated changes are subject to linter complaints?

Yes.

gabrielschulhof
gabrielschulhof reviewed Mar 28, 2021
View reviewed changes
Copy link
Contributor

@gabrielschulhof gabrielschulhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does more than rename N-API to Node-API. There are also a bunch of whitespace changes. Would it be OK to just stick to the renaming? Otherwise it may create some churn.

@gabrielschulhof
Copy link
Contributor

Oh. Didn't see the convo. NM.

@gabrielschulhof
Copy link
Contributor

gabrielschulhof commented Mar 28, 2021 •
edited
Loading

CI:

Version Job Status
main https://ci.nodejs.org/job/node-test-node-addon-api-new/3853/ ✓
v15.x https://ci.nodejs.org/job/node-test-node-addon-api-new/3854/ hung
https://ci.nodejs.org/job/node-test-node-addon-api-new/3858/ ✓
v14.x https://ci.nodejs.org/job/node-test-node-addon-api-new/3855/ ✓
v12.x https://ci.nodejs.org/job/node-test-node-addon-api-new/3856/ ✓
v10.x https://ci.nodejs.org/job/node-test-node-addon-api-new/3857/ ✓

gabrielschulhof pushed a commit that referenced this pull request Mar 29, 2021
@NickNaso @gabrielschulhof
src: rename N-API with Node-API on comments
6280236 
Also fixed lint errors.

Fixes: #952
PR-URL: #953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
@gabrielschulhof
Copy link
Contributor

Landed in 6280236.

deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this pull request Sep 23, 2021
@NickNaso
src: rename N-API with Node-API on comments
5110815 
Also fixed lint errors.

Fixes: nodejs#952
PR-URL: nodejs#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
deepakrkris pushed a commit to deepakrkris/node-addon-api that referenced this pull request Oct 15, 2021
@NickNaso
src: rename N-API with Node-API on comments
5c5d885 
Also fixed lint errors.

Fixes: nodejs#952
PR-URL: nodejs#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
src: rename N-API with Node-API on comments
662e4f4 
Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
src: rename N-API with Node-API on comments
ce500e6 
Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
src: rename N-API with Node-API on comments
31c9fbf 
Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
@baby636 baby636 mentioned this pull request Jun 5, 2023
Open
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
src: rename N-API with Node-API on comments
f8294e6 
Also fixed lint errors.

Fixes: nodejs/node-addon-api#952
PR-URL: nodejs/node-addon-api#953
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickNaso @gabrielschulhof @legendecas