Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Update BooleanObject::New signature in v8.h #90

Closed
munyirik opened this issue Jul 1, 2016 · 0 comments
Closed

Update BooleanObject::New signature in v8.h #90

munyirik opened this issue Jul 1, 2016 · 0 comments

Comments

@munyirik
Copy link

munyirik commented Jul 1, 2016

The signature of BooleanObject::New in chakrashim should match the one in v8.

Found the issue in a check that nan does when NODE_MODULE_VERSION is >= 48:
https://github.com/nodejs/nan/blob/master/nan_implementation_12_inl.h#L40
kunalspathak added a commit to kunalspathak/node-chakracore that referenced this issue Jul 7, 2016
@kunalspathak
chakrashim: fix for nan compatibility
7e240e9 
Fixes: nodejs#90
kunalspathak added a commit to kunalspathak/node-chakracore that referenced this issue Jul 7, 2016
@kunalspathak
chakrashim: fix for nan compatibility
793f508 
Fixes: nodejs#90
@kunalspathak kunalspathak mentioned this issue Jul 7, 2016
Merged
2 tasks
kunalspathak added a commit to kunalspathak/node-chakracore that referenced this issue Jul 13, 2016
@kunalspathak
chakrashim: fix for nan compatibility
21bd447 
PR-URL: nodejs#93
Reviewed-By: Jianchun Xu <Jianchun.Xu@microsoft.com>
Fixes: nodejs#90
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@munyirik