This repository was archived by the owner on Oct 15, 2020. It is now read-only.
lib: removing contents of v8 module under chakracore #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
digitalinfinity
approved these changes
Mar 8, 2018
sethbrenith
approved these changes
Mar 8, 2018
kfarnung
approved these changes
Mar 9, 2018
lib/v8.js
Outdated
| 'use strict'; | ||
|
|
||
| if (process.jsEngine === 'chakracore') { | ||
| return; |
Contributor
There was a problem hiding this comment.
Looks like you have four spaces here, this is probably the cause of the linter failure in CI.
Contributor
|
The v8 module uses functionality which is not supported by chakracore. Rather than expose stubs which have unexpected behavior, we now do not expose anything in the v8 module, so dependant modules can do feature detection. PR-URL: nodejs#491 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
MSLaguana
force-pushed
the
disableV8Module
branch
from
d3df16c to
1e7456e
Compare
MSLaguana
added a commit
that referenced
this pull request
Mar 9, 2018
The v8 module uses functionality which is not supported by chakracore. Rather than expose stubs which have unexpected behavior, we now do not expose anything in the v8 module, so dependant modules can do feature detection. PR-URL: #491 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Contributor
Author
|
Landed in bbcf831 |
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 9, 2018
The v8 module uses functionality which is not supported by chakracore. Rather than expose stubs which have unexpected behavior, we now do not expose anything in the v8 module, so dependant modules can do feature detection. PR-URL: nodejs#491 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v8 module uses functionality which is not supported by chakracore.
Rather than expose stubs which have unexpected behavior, we now do not
expose anything in the v8 module, so dependant modules can do feature
detection.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes