Skip to content
This repository was archived by the owner on Oct 15, 2020. It is now read-only.

lib: removing contents of v8 module under chakracore #491

Closed
MSLaguana wants to merge 1 commit into from
Closed

lib: removing contents of v8 module under chakracore #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/v8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@

'use strict';

if (process.jsEngine === 'chakracore') {
return;
}

const { Buffer } = require('buffer');
const { ERR_INVALID_ARG_TYPE } = require('internal/errors').codes;
const {
Expand Down
5 changes: 5 additions & 0 deletions test/parallel/parallel.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,11 @@ test-fs-readdir-stack-overflow : SKIP
# in a particular way which is true for v8 but not true for charkacore
test-string-decoder-end : SKIP

# These tests use the v8 module which chakracore does not support
test-process-exception-capture-should-abort-on-uncaught-setflagsfromstring : SKIP
test-v8-flag-type-check : SKIP
test-v8-stats : SKIP

[$jsEngine==chakracore && $arch==x64]
# These tests are failing for Node-Chakracore and should eventually be fixed
test-buffer-includes : SKIP
Expand Down