This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Ignore : ttdReplayDebugUri not initialized #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1.10>master] [MERGE #5504 @sigatrev] Code Quality: use legalizePostRegAlloc flag on Func instead of passing bool to Legalizers Merge pull request #5504 from sigatrev:users/magardn/legalize ARM and ARM64 legalizers behave differently before and after register allocation. We've had bugs in the past where, mainly through static helper functions similar to Lowerer::InsertMove where we've had the flag wrong. This commit adds a flag on Func to tell the legalizer if it should behave as if register allocation has happened or not, and removes the need to pass the flags. The flag was not used on x86 and x64 There were a couple of places where the flag passed did not agree with whether register allocation has finished, in particular LinearScan::InsertLea (passed the flag true) and ARM and ARM64 LowererMD::ChangeToAssign (always passed false). I've added an RAII auto-restore helper to change the flag on the Func while those calls are in progress . While not ideal, it does have the benefit of being mroe expressive. I'm using a new flag instead of the existing (dbg only) isPostRegAlloc flag because the flag can be temporarily overriden. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5518 @VSadov] Relaxing an assert in TinyDictionary Merge pull request #5518 from VSadov:tiny It is possible and ok for the `data` part of the dictionary to contain `FF`. The assert that we have in `TryGetValue` could get triggered if an unsuccessfull lookup goes through such value. The added test code does that, as an example. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5521 @kfukuda2] Fixing broken build for ChakraFull Merge pull request #5521 from kfukuda2:testFix Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 4fce5bf as of 2018-07-25 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5519 @akroshg] OS 18333466 : Recursion in the generator next call. Merge pull request #5519 from akroshg:generator Moving exception throw out from the catch handler. Otherwise we will throw hard stack overflow. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5522 @MikeHolman] fix issue where helper call is reading varargs incorrectly on linux Merge pull request #5522 from MikeHolman:users/michhol/vararghelperbug Fixes #5503 Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5490 @rajatd] Fix field types in InlineeCallInfo. OS #15566165 Merge pull request #5490 from rajatd:inlineeCallInfo-type Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5524 @atulkatti] MSFT:18103621 During ReleasePagesShutdown allocators may not have been closed yet, if we are cleaning up the blocks in RecyclerSweep instance. Merge pull request #5524 from atulkatti:Bug18103621.ShutdownCleanupAssert.1 Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 71e98db as of 2018-07-26 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5526 @leirocks] fix CustomHeap Page::CanAllocate calculation Merge pull request #5526 from leirocks:customheap CustomHeap page use power of 2 bucketing, CanAllocate uses linear method to find the big enough chunk to split later there's check again while allocation from this page, and the allocation would fail so it's not a security issue Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5530 @irinayat-MS] 'length' property of arrays should have same delete semantics as own non-indexed non-configurable props Merge pull request #5530 from irinayat-MS:DeleteArrayLength Fixes OS#16382392 The assert has caught non-conforming behaviour of delete on 'length' property of Arrays. In strict mode delete should throw because 'length' is own and non-configurable. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5525 @leirocks] Use seperate error for xdata registration failures Merge pull request #5525 from leirocks:xdata Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5506 @aneeshdk] OS:12625415:Don't add let attribute for built-in arguments symbol when function has non-simple parameters Merge pull request #5506 from aneeshdk:ArgsSymPropertyLetIssue In cached scope when we create the scope object we pass let attribute for all formals. This was marking the built-in arguments symbol also with let. This change removes it. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5536 @rajatd] Handle failure to reserve pre-reserved section when initializing server thread context. OS#15209418 Merge pull request #5536 from rajatd:prereserved If we failed to reserve memory for the pre-reserved section when initializing the jit server thread context, when the jit process does the reservation, the client process has no way of knowing the start address of the pre-reserved section. Instead, don't try to allocate memory for jitted code in pre-reserved section if we couldn't reserve when initializing server thread context Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5533 @MSLaguana] Removing assert/special casing of javascript proxy queryObjectInterface Merge pull request #5533 from MSLaguana:removeProxyComSpecialCase JavaScript Proxies don't support any COM interfaces; but neither does RecyclableObject, and that doesn't assert. The default handling should be correct in this case. Fixes OS:16539184 Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5537 @dilijev] OS#18178361: Don't call JavascriptWeakMap::Clear on shutdown since ScriptContext may have already been freed. Merge pull request #5537 from dilijev:weakmap-clear Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5539 @atulkatti] MSFT:18210422 Remove the dummy field in NoResizeLock that adds 8 bytes to all BaseDictionary instances using NoResizeLock. Merge pull request #5539 from atulkatti:Bug18210422.RevertBaseDictionarySizeChange.1 This was added only to help with prefast analysis. I will need to add some prefast ignore statements after looking at the failures. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 9009fe3 as of 2018-07-27 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5540 @sethbrenith] Avoid copying strings in (de|en)codeURI(Component)? and trim Merge pull request #5540 from sethbrenith:user/sethb/encode * The last step of Encode and Decode was copying the buffer for no reason; skip that copy * Often the input to Encode or Decode doesn't require any transformation, so return the original string in that case * Likewise, avoid creating new substrings for trimmed strings if nothing needs to be trimmed Related to OS:17754314 Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5497 @irinayat-MS] Move re-throw of exception out of catch Merge pull request #5497 from irinayat-MS:StackOverflow Fixes OS.18246154 Re-throw from catch doesn't unwind the stack (only resets the active frame pointer) so, if there are nested try/catch blocks that refrow, the stack keeps growing, which is unhelpful if the initial exception is trying to prevent Stack Overflow. To avoid this, move re-throw outside of the catch (so the stack fully unwinds on each handling site). Took the opportunity to add more test coverage for typeof and fix exception handling deviations from the spec (and V8). Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5538 @dilijev] OS#17035705: Mark SetItem as JS_REENTRANT in CopyWithinHelper. Merge pull request #5538 from dilijev:copywithin-reentrant Found by OSS-Fuzz Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5535 @rajatd] Don't add compensation code for array values in prepass. OS#17527968 Merge pull request #5535 from rajatd:avt-array With aggressive transfer of values in loop prepass, an assignment of an array will result in an Array kind value for the dst (without value transfer in prepass, it would have been a Generic kind value). Globopt, when trying to merge two Array kind values from two edges, will try to insert compensation code if, for example, the length sym on the two values is different. We are currently hitting an assert that we should only be inserting compensation code in the main pass of the loop. Before AVT, we wouldn't even have tried to insert compensation because the value types on the two edges would be different. Given the timeframe and release being shutdown, I'm changing the code so it only inserts compensation code in the main pass (instead of inserting compensation in prepass). This matches the behaviour to what we had before AVT. Thanks @meg-gupta for the reduction on this one. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[MERGE #5527 @kfarnung] Update JsInstanceOf to use OP_IsInst Merge pull request #5527 from kfarnung:jsinstanceof `OP_IsInst` correctly handles the ES6 `Symbol.hasInstance` property when determining whether an object is an instance of a constructor. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5547 @meg-gupta] OS#15997192: Disable strict valuetype assert for hoistable syms Merge pull request #5547 from meg-gupta:disableassert The assert says that for a hoistable value, if its valuetype is primitive in the loop landing pad, it should be atleast LikelyPrimitive inside the loop. This assert does not hold true in a few cases when we force specialize syms in the loop landing pad. Ex : landingPad: a = v1; b = v1; loop : b = v2; // forces float conversion in landing pad c = a; jump loop During force specializing in loop landing pad of b, both a and b have the same valueinfo, so they transition to a DefiniteFloat. This takes b to definite float in the loop landing pad but not inside the loop. We do not have a way to force Specialize a in the loop, we cannot assume force specializing b again in the loop will update the valueInfo of a, because they may have different value numbers in the loop. Since we don't have a way to lookup values by valueNumber, there is no easy way to fix this gap currently. Added test to keep track of this gap. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5528 @Cellule] Post Op Bailout before first instr Merge pull request #5528 from Cellule:users/micfer/handlerscope Handle cases where we try to bailout before the first bytecode instr. OS#17686612 Right now, it is possible to have a post-op bailout on LdScopeHandler which is added in IRBuilder. I am not sure how to write a test that triggers this path, it seems specific to browser/node scenario I have checked with @rajatd that a bailout there is fine since we will re-execute the code in the bailout path (more specifically in the first iteration of the interpreter). Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5219 @rhuanjl] Allow 'in' to terminate expressions in for fixes #5203 Merge pull request #5219 from rhuanjl:fixYieldIn Attempt at fixing issue #5203 Based on #5216 Not 100% sure I've got this right but it passes the mentioned cases and doesn't regress anything I'm aware of. cc @zenparsing @akroshg Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[MERGE #5545 @boingoing] Support deferred stubs for functions declared in parameter scope Merge pull request #5545 from boingoing:deferredstubsforparameterscope We previously skipped creating deferred function stubs for functions declared in the parameter scope. This throws-off the order of nested functions under functions with children defined in the parameter scope. We worked-around this by not using deferred stubs in parents with default arguments. Add support for creating deferred stubs and using them when parsing function parameter lists. Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
[1.10>master] [MERGE #5552 @MSLaguana] Modifying build definition to reduce external dependencies in CI Merge pull request #5552 from MSLaguana:user/jithomso/newMicrobuild Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 2293d83 as of 2018-07-28 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 04124ef as of 2018-07-30 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 744291b as of 2019-02-08 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 47423c1 as of 2019-02-13 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 17c2125 as of 2019-02-14 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 4151392 as of 2019-02-15 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge aa4f174 as of 2019-02-16 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
YannDelorme
changed the title
…ster Merge a4b8de5 as of 2019-02-20 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge bc16031 as of 2019-02-22 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge e2ea5ef as of 2019-02-23 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge df9b1d2 as of 2019-02-25 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge ecab999 as of 2019-03-02 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 24d596d as of 2019-03-12 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 2e14bba as of 2019-03-13 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 37183ae as of 2019-03-28 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 3890882 as of 2019-04-06 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge aa64a4b as of 2019-04-11 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 4805fde as of 2019-04-23 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge e1c4cc0 as of 2019-05-15 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 08a06c7 as of 2019-06-12 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 4b8c718 as of 2019-06-18 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge e3ec564 as of 2019-07-10 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 372999e as of 2019-08-08 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge bc53ba2 as of 2019-08-14 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 007b624 as of 2019-09-06 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge f0b74bf as of 2019-09-11 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 4ad14a0 as of 2019-10-09 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 2dffd26 as of 2019-10-16 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge e1414ed as of 2019-11-16 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 0568f4e as of 2019-12-18 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
…ster Merge 770c8dc as of 2019-12-21 This commit was automatically generated. For any problems, please contact jackhorton Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ordre to fix TTD issues
replace in node_options.cc
AddOption("--replay-debug",
"replay and debug using recording log",
&PerProcessOptions::ttdReplayUri);
with
AddOption("--replay-debug",
"replay and debug using recording log",
&PerProcessOptions::ttdReplayDebugUri);