-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update maintaining-dependencies.md on major v8 update #699
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #699 +/- ##
=======================================
Coverage 83.38% 83.38%
=======================================
Files 37 37
Lines 4158 4158
=======================================
Hits 3467 3467
Misses 691 691 ☔ View full report in Codecov by Sentry. |
Thanks for the PR! The changes look good to me, but unfortunately we can't do them in Could you move the code to a new task that is run between |
@targos I have moved the task between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thank you!
landed nodejs/node#48081 |
)" This reverts commit a8b1812.
Update
doc/contributing/maintaining/maintaining-dependencies.md
on major V8 updates. Marked as draft in order to wait for nodejs/node#48081 to land