-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add version to maintaining-dependencies.md dependencies list and automate the update #48081
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that the existing update scripts are already not pretty, but I still don't think we should add duplicate code to all of them. Could you please DRY the logic?
@tniessen I'm agree with you. I started recently to collaborate on node and I wasn't sure if I could (or not) create new files. Anyway if this refactor is ok, than I can continue with the other dependencies. |
why do you say they dont commit any change? The commit is done in the action that triggers all these scripts: node/.github/workflows/tools.yml Line 295 in 959142a
the version of undici is currently 5.22.1 https://github.com/nodejs/node/blob/main/deps/undici/src/package.jsonyou can update it with NEW_VERSION https://github.com/nodejs/node/blob/main/tools/dep_updaters/update-undici.shFor zlib we might want to use latest version + commit hash. For v8 we have automated only patch update so if it's a major update it has to be done manually. postject should be like every other dependency |
7bf0db3
to
ce7111a
Compare
@marco-ippolito I have added version to |
pr for histogram dep_updater : #48171 landed |
af728dd
to
86e0c9d
Compare
Refs: nodejs/security-wg#973 Most of the duplicated code in all the dependencies updaters has been moved in the `utils.sh` file
@marco-ippolito added version for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Landed in c541153 |
Refs: nodejs/security-wg#973 Most of the duplicated code in all the dependencies updaters has been moved in the `utils.sh` file PR-URL: #48081 Refs: nodejs/security-wg#973 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Refs: nodejs/security-wg#973 Most of the duplicated code in all the dependencies updaters has been moved in the `utils.sh` file PR-URL: nodejs#48081 Refs: nodejs/security-wg#973 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Refs: nodejs/security-wg#973 Most of the duplicated code in all the dependencies updaters has been moved in the `utils.sh` file PR-URL: nodejs#48081 Refs: nodejs/security-wg#973 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Add version to
doc/contributing/maintaining/maintaining-dependencies.md
dependencies list and automate the updateRefs: nodejs/security-wg#973
Most of the duplicated code in all the dependencies updaters has been moved in the
utils.sh
fileThis is the list of all the dependencies: