test: use Travis CI to run tests on every pull request #1752
Conversation
cclauss
force-pushed
the
patch-2
branch
2 times, most recently
from
40eceb4
to
e2d38ab
Compare
|
I don't know how to hook this up and don't think I have permissions either. @nodejs/automation can you help? |
|
Someone who has admin rights would need to go to https://travis-ci.org/nodejs/node-gyp and flip the repo switch on. |
|
It's not quite that simple, or at least it never used to be, because of a policy about giving org privs to external services. There's hoops that need to be jumped through to get the github-bot to react to changes in this repo and trigger Travis runs (although that may have changed?). |
|
Is there an internal test runner available? Jenkins or something? |
|
I enabled it. We have the GitHub app so the url is https://travis-ci.com/nodejs/node-gyp |
|
@rvagg it's simpler since some time with github app because we can give permissions to Travis on a per repository basis (it's in the organization's config) |
|
Thanks much!! Build in progress... https://travis-ci.com/nodejs/node-gyp/pull_requests |
|
Shouldn't it end up in a failed state instead of errored? |
|
The tests now pass with one noqa TODO added (#1772). I am unclear what is the difference between failed and errored but I do know that all these issues and more for both Python 2 and Python 3 were flattened in https://github.com/refack/GYP |
|
I think that anything that fails outside of the "script" phase results in an error.
|
|
Bump on this one please. |
|
👍 will merge this if you fix up the commits, make it 2 or 3 commits - one for travis, one or two for the python fixes as you see fit. |
|
also, there's a "TODO" in there with noqa, is that something that needs to be resolved prior to landing this? |
This is a second attempt at nodejs#1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.
|
I am OK with leaving the TODO open as it has been working without issue to date. Sometimes that situation can be caused by implicit imports. |
| @@ -1182,7 +1182,7 @@ def LoadVariablesFromVariablesDict(variables, the_dict, the_dict_key): | |||
| if variable_name in variables: | |||
| # If the variable is already set, don't set it. | |||
| continue | |||
| if the_dict_key is 'variables' and variable_name in the_dict: | |||
| if the_dict_key == 'variables' and variable_name in the_dict: | |||
There was a problem hiding this comment.
Identity is not the same thing as equality in Python.
Proof:
>>> the_dict_key = 'variable'
>>> the_dict_key += 's'
>>> the_dict_key == 'variables'
True
>>> the_dict_key is 'variables'
False
>>>
This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>
|
landed in 051b6ed |
This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>
Use flake8 to automate the discovery of Python syntax errors and undefined names.
This is a second attempt at #1336 which got into a bad git-state...
Checklist
npm install && npm testpassesDescription of change
There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.