assert: doesNotThrow doesn't show message

[pkorzeniewski]

In the documentation, assert.doesNotThrow takes two arguments: (block, [message]), but calling

assert.doesNotThrow(function() {
    // some code throwing an error
}, "Error occured");

won't display the "Error occured" message, but the thrown error instead. I've inspected the assert.js file, and the problem is probably caused by line 304:

if (!shouldThrow && expectedException(actual, expected)) {

expectedException will always return false, because expected is always set to null

 if (util.isString(expected)) {
    message = expected;
    expected = null;
  }

[jasnell]

There is a new PR opened in nodejs/node tracking this issue. Closing here.