This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
assert: respect assert.doesNotThrow message. #6470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses nodejs#6400. Special handling to detect when user has supplied a custom message. Added a test for user message.
| @@ -299,7 +299,11 @@ function _throws(shouldThrow, block, expected, message) { | |||
| fail(actual, expected, 'Missing expected exception' + message); | |||
| } | |||
|
|
|||
| if (!shouldThrow && expectedException(actual, expected)) { | |||
| if (!shouldThrow && | |||
| actual instanceof Error && | |||
When testing if `actual` value is an error use `util.isError` instead of `instanceof`.
|
@tjfontaine had you had the opportunity to look at this one? Seems good? :) |
|
@diversario ... unfortunately it doesn't look like this was ever reviewed further. Given that this involves a change in functionality, it would likely be best to close this PR here and open a new one against the active dev channel at http://github.com/nodejs/node if this is something you'd still like to pursue. |
|
New issue in nodejs/node created to track this. The change would need to be made there and potentially cherry picked to v0.12 or v0.10. Closing this here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6400.
Special handling to detect when user has supplied a custom message.
Added a test for user message.