Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Add NODE_EXTERN to node::Start #3376

Closed
wants to merge 1 commit into from
Closed

Conversation

joelrbrandt
Copy link

I'm building node as a DLL on Windows (which works awesome by the way) for embedding inside another application.

node::Start isn't currently exported. It's a useful function.

Any chance we can add this to both v0.6 and master? Thanks!

@bnoordhuis
Copy link
Member

I'll be happy to land it in master but not in v0.6, I don't want to change the ABI in stable releases in any way. Can you sign the CLA?

@joelrbrandt
Copy link
Author

@bnoordhuis sounds good. I signed the CLA.

I also created #3378 that pulls in to master.

Closing.

@joelrbrandt joelrbrandt closed this Jun 6, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants