Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

add NODE_EXTERN to node::Start #3378

Closed
wants to merge 1 commit into from

Conversation

joelrbrandt
Copy link

@bnoordhuis
(same as #3376 but with different destination branch)

I'm building node as a DLL on Windows (which works awesome by the way) for embedding inside another application.

node::Start isn't currently exported. It's a useful function.

Thanks!

@bnoordhuis
Copy link
Member

Thanks Joel, landed in b9c5eee.

@bnoordhuis bnoordhuis closed this Jun 6, 2012
@Kosta-Github
Copy link

@bnoordhuis would you also be willing to add something like this joelrbrandt@b903e8a in order to support the creation of DLLs (windows) and shared libs (Linux/OSX) as well? I am also thinking about embedding node into an existing hosting c++ application for providing scripting functionality...

@bnoordhuis
Copy link
Member

@Kosta-Github That commit in itself is not enough to produce a working library but see #7336.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants