Fixes for #48 #49
Closed
Fixes for #48 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.7. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
Synchronize source files list with upstream's BUILD.gn.
Adds `isBigInt64Array` and `isBigUint64Array`.
Also exclude isBigInt from test because `typeof value === 'bigint'` can be used instead.
v8.getHeapSpaceStatistics() now includes read_only_space in its results. Update test-v8-stats.js to account for this. Fixes: nodejs#44
This commit updates the following postmortem metadata constants: - v8dbg_class_SharedFunctionInfo__code__Code - This is now combined with SharedFunctionInfo's function_data. - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object - V8 commit: v8/v8@51ded9d - v8dbg_class_SharedFunctionInfo__raw_name__Object and - v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo - These are now combined as name_or_scope_info. - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object - V8 commit: v8/v8@74a663b Fixes: nodejs#44
This commit updates the following postmortem metadata constant: - v8dbg_class_SharedFunctionInfo__compiler_hints__int - Renamed: v8dbg_class_SharedFunctionInfo__flags__int - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b Fixes: nodejs#48
This commit renames V8DBG_CLASS_SHAREDFUNCTIONINFO__RAW_NAME__OBJECT to V8DBG_CLASS_SHAREDFUNCTIONINFO__NAME_OR_SCOPE_INFO__OBJECT following an upstream change.
|
Needs a rebase but last two commits LGTM. |
|
Thanks. Pushed to canary-base in nodejs/node@a95b694 and nodejs/node@e2bdca5 |
nodejs-ci
pushed a commit
that referenced
this pull request
Oct 6, 2018
Reverting this enables us to provide slower, but longer-lasting
replacements for the deprecated APIs.
Original commit message:
Put back deleted V8_DEPRECATE_SOON methods
This partially reverts
https://chromium-review.googlesource.com/c/v8/v8/+/1177861,
which deleted many V8_DEPRECATE_SOON methods rather than moving them to
V8_DEPRECATED first. This puts them back and marks them V8_DEPRECATED.
Note V8_DEPRECATED that were deleted in the same CL stay deleted.
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
Bug: v8:7786, v8:8240
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I00330036d957f98dab403465b25e30d8382aac22
Reviewed-on: https://chromium-review.googlesource.com/1251422
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.0@{#49}
Cr-Branched-From: 6e2adae6f7f8e891cfd01f3280482b20590427a6-refs/heads/7.0.276@{#1}
Cr-Branched-From: bc08a8624cbbea7a2d30071472bc73ad9544eadf-refs/heads/master@{#55424}
Refs: v8/v8@9136dd8
Refs: nodejs/node#23122
PR-URL: nodejs/node#23158
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the SmartOS and postmortem debugging metadata in #48. I could not reproduce the macOS failure locally.