deps: update v8.gyp, fix torque on windows #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
Synchronize source files list with upstream's BUILD.gn.
This reverts commit f02b74d.
v8.getHeapSpaceStatistics() now includes read_only_space in its results. Update test-v8-stats.js to account for this. Fixes: #44
This commit updates the following postmortem metadata constants: - v8dbg_class_SharedFunctionInfo__code__Code - This is now combined with SharedFunctionInfo's function_data. - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object - V8 commit: v8/v8@51ded9d - v8dbg_class_SharedFunctionInfo__raw_name__Object and - v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo - These are now combined as name_or_scope_info. - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object - V8 commit: v8/v8@74a663b - v8dbg_class_SharedFunctionInfo__compiler_hints__int - Renamed: v8dbg_class_SharedFunctionInfo__flags__int - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b Fixes: #44 Fixes: #48
This commit renames V8DBG_CLASS_SHAREDFUNCTIONINFO__RAW_NAME__OBJECT to V8DBG_CLASS_SHAREDFUNCTIONINFO__NAME_OR_SCOPE_INFO__OBJECT following an upstream change.
As per Node.js docs, vm.Script instance is not bound to any context. However, this test was expecting otherwise and depended on implementation details which are going to change. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1013581
Teach v8.gyp to build and run torque, V8's DSL for generating builtins.
until 8466b71ad81a71a7fccace84c034af251591c5c0
Turn on exceptions and RTTI, torque uses both. They were already enabled on UNIX platforms.
Use of Internals::IsValidSmi() looks questionable anyway, it won't work right when cross-compiling from 32 bits to 64 bits or vice versa.
|
@bnoordhuis is the second commit to fix "unresolved externals" errors? |
nodejs-ci
force-pushed
the
canary
branch
2 times, most recently
from
0876dce to
89f6b64
Compare
|
I just tested this on my Windows machine and it works! Are you going to upstream the change in torque's file? |
|
Yes, I just need to get back to this. Bit behind on schedule due to a back injury. |
Closed
Closed
nodejs-ci
force-pushed
the
canary
branch
2 times, most recently
from
1c20870 to
d97ee1b
Compare
nodejs-ci
force-pushed
the
canary
branch
5 times, most recently
from
056b78f to
5af732e
Compare
nodejs-ci
force-pushed
the
canary
branch
2 times, most recently
from
b2733b8 to
491eb0f
Compare
|
Superseded by #61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on exceptions and RTTI, torque uses both. They were already
enabled on UNIX platforms.
CI: https://ci.nodejs.org/job/node-test-pull-request/14616/