Skip to content

Commit

Permalink
src: nuke deprecated and un-used enum members in OptionEnvvarSettings
Browse files Browse the repository at this point in the history
Delete deprecated an never used enum options `kAllowedInEnvironment`
and `kDisallowedInEnvironment` in `OptionEnvvarSettings`

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #53079
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
  • Loading branch information
juanarbol authored Nov 5, 2024
1 parent 58a7b00 commit 03dcd70
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 0 additions & 4 deletions src/node.h
Original file line number Diff line number Diff line change
Expand Up @@ -374,10 +374,6 @@ enum OptionEnvvarSettings {
// Disallow the options to be set via the environment variable, like
// `NODE_OPTIONS`.
kDisallowedInEnvvar = 1,
// Deprecated, use kAllowedInEnvvar instead.
kAllowedInEnvironment = kAllowedInEnvvar,
// Deprecated, use kDisallowedInEnvvar instead.
kDisallowedInEnvironment = kDisallowedInEnvvar,
};

// Process the arguments and set up the per-process options.
Expand Down
4 changes: 2 additions & 2 deletions typings/internalBinding/options.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export interface OptionsBinding {
aliases: Map<string, string[]>;
};
envSettings: {
kAllowedInEnvironment: 0;
kDisallowedInEnvironment: 1;
kAllowedInEnvvar: 0;
kDisallowedInEnvvar: 1;
};
noGlobalSearchPaths: boolean;
shouldNotRegisterESMLoader: boolean;
Expand Down

0 comments on commit 03dcd70

Please sign in to comment.