src: nuke deprecated and un-used enum members in OptionEnvvarSettings
#53079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete deprecated an never used enum options `kAllowedInEnvironment` and `kDisallowedInEnvironment` in `OptionEnvvarSettings` Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
nodejs-github-bot
added
c++
lpinca
approved these changes
May 21, 2024
|
semver-major? |
Is it? Honestly, idk. |
jasnell
approved these changes
May 25, 2024
marco-ippolito
added
semver-major
github-actions
bot
removed
the
request-ci
juanarbol
added
the
author ready
|
cc @nodejs/tsc as this is a semver-major |
anonrig
approved these changes
Nov 3, 2024
RafaelGSS
approved these changes
Nov 4, 2024
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 03dcd70 |
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Delete deprecated an never used enum options `kAllowedInEnvironment` and `kDisallowedInEnvironment` in `OptionEnvvarSettings` Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: nodejs#53079 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete deprecated an never used enum options
kAllowedInEnvironmentandkDisallowedInEnvironmentinOptionEnvvarSettingsI'm not too sure if this is gonna be ok in CITGM, but, lets give it a try!