Skip to content

Commit

Permalink
zlib: report premature ends earlier
Browse files Browse the repository at this point in the history
Report end-of-stream when decompressing when we detect it,
and do not wait until the writable side of a zlib stream
is closed as well.

Refs: #26332

PR-URL: #26363
Refs: #26332
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
addaleax authored and BridgeAR committed Mar 3, 2019
1 parent a0778a9 commit 28db96f
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 0 deletions.
10 changes: 10 additions & 0 deletions lib/zlib.js
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,16 @@ function processCallback() {
return;
}

if (availInAfter > 0) {
// If we have more input that should be written, but we also have output
// space available, that means that the compression library was not
// interested in receiving more data, and in particular that the input
// stream has ended early.
// This applies to streams where we don't check data past the end of
// what was consumed; that is, everything except Gunzip/Unzip.
self.push(null);
}

// finished with the chunk.
this.buffer = null;
this.cb();
Expand Down
33 changes: 33 additions & 0 deletions test/parallel/test-zlib-premature-end.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
'use strict';
const common = require('../common');
const zlib = require('zlib');
const assert = require('assert');

const input = '0123456789'.repeat(4);

for (const [ compress, decompressor ] of [
[ zlib.deflateRawSync, zlib.createInflateRaw ],
[ zlib.deflateSync, zlib.createInflate ],
[ zlib.brotliCompressSync, zlib.createBrotliDecompress ]
]) {
const compressed = compress(input);
const trailingData = Buffer.from('not valid compressed data');

for (const variant of [
(stream) => { stream.end(compressed); },
(stream) => { stream.write(compressed); stream.write(trailingData); },
(stream) => { stream.write(compressed); stream.end(trailingData); },
(stream) => { stream.write(Buffer.concat([compressed, trailingData])); },
(stream) => { stream.end(Buffer.concat([compressed, trailingData])); }
]) {
let output = '';
const stream = decompressor();
stream.setEncoding('utf8');
stream.on('data', (chunk) => output += chunk);
stream.on('end', common.mustCall(() => {
assert.strictEqual(output, input);
assert.strictEqual(stream.bytesWritten, compressed.length);
}));
variant(stream);
}
}

0 comments on commit 28db96f

Please sign in to comment.