zlib: report premature ends earlier #26363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report end-of-stream when decompressing when we detect it, and do not wait until the writable side of a zlib stream is closed as well. Refs: nodejs#26332
cjihrig
approved these changes
Feb 28, 2019
BridgeAR
approved these changes
Mar 1, 2019
jasnell
approved these changes
Mar 1, 2019
|
Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21120/ (:heavy_check_mark:) |
addaleax
added
the
author ready
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 3, 2019
Report end-of-stream when decompressing when we detect it, and do not wait until the writable side of a zlib stream is closed as well. Refs: nodejs#26332 PR-URL: nodejs#26363 Refs: nodejs#26332 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 28db96f 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Mar 4, 2019
Report end-of-stream when decompressing when we detect it, and do not wait until the writable side of a zlib stream is closed as well. Refs: #26332 PR-URL: #26363 Refs: #26332 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Mar 12, 2019
Closed
kevinoid
added a commit
to kevinoid/inflate-auto
that referenced
this pull request
Oct 27, 2020
Signal the end of data when format emits 'end' so that early 'end' (e.g. due to data after compressed data ends since nodejs/node#26363) so that InflateAuto behaves the same as the zlib streams. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report end-of-stream when decompressing when we detect it,
and do not wait until the writable side of a zlib stream
is closed as well.
Refs: #26332
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes