Skip to content

Commit

Permalink
build: do not depend on cp in PATH
Browse files Browse the repository at this point in the history
Use gyp’s own copying mechanism instead.

It’s not really clear which UNIX utils exactly are needed to build on
Windows, but this is an easier fix (at least for me) than figuring
out how to get `cp` into the `PATH` in all cases, and judging
from the issue I’m not the only one who ran into this.

Fixes: #20272

PR-URL: #20296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
addaleax authored and MylesBorins committed May 4, 2018
1 parent 701f536 commit 2ce4b7c
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -680,13 +680,13 @@
'toolsets': ['host'],
'conditions': [
[ 'v8_enable_inspector==1', {
'actions': [
'copies': [
{
'action_name': 'v8_inspector_copy_protocol_to_intermediate_folder',
'inputs': [ 'deps/v8/src/inspector/js_protocol.pdl' ],
'outputs': [ '<(SHARED_INTERMEDIATE_DIR)/js_protocol.pdl' ],
'action': [ 'cp', '<@(_inputs)', '<(SHARED_INTERMEDIATE_DIR)' ],
},
'destination': '<(SHARED_INTERMEDIATE_DIR)',
'files': ['deps/v8/src/inspector/js_protocol.pdl']
}
],
'actions': [
{
'action_name': 'v8_inspector_convert_protocol_to_json',
'inputs': [
Expand Down

0 comments on commit 2ce4b7c

Please sign in to comment.