Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build break on windows #20272

Closed
fs-eire opened this issue Apr 25, 2018 · 2 comments
Closed

build break on windows #20272

fs-eire opened this issue Apr 25, 2018 · 2 comments
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.

Comments

@fs-eire
Copy link
Contributor

fs-eire commented Apr 25, 2018

  • Version: master
  • Platform: Windows
  • Subsystem:

Change fda2b9a introduced a build break in Windows ( without cygwin installed ).

'cp' is not recognized as an internal or external command

@ak239
@Hackzzila
Copy link
Contributor

I had the same issue earlier, I just had to reinstall git and add the bash tools in the path. This is mentioned here.

@fs-eire
Copy link
Contributor Author

fs-eire commented Apr 25, 2018 •
edited
Loading

I see... I thought UNIX tools are optional for building. (actually it is true before this commit)

@vsemozhetbyt vsemozhetbyt added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Apr 25, 2018
addaleax added a commit to addaleax/node that referenced this issue Apr 25, 2018
@addaleax
build: do not depend on cp in PATH
da300ff 
Use gyp’s own copying mechanism instead.

It’s not really clear which UNIX utils exactly are needed to build on
Windows, but this is an easier fix (at least for me) than figuring
out how to get `cp` into the `PATH` in all cases, and judging
from the issue I’m not the only one who ran into this.

Fixes: nodejs#20272
@addaleax addaleax mentioned this issue Apr 25, 2018
Closed
2 tasks
alexeykuzmin pushed a commit to electron/node that referenced this issue Apr 30, 2018
@addaleax @alexeykuzmin
build: do not depend on cp in PATH
27ef68e 
Use gyp’s own copying mechanism instead.

It’s not really clear which UNIX utils exactly are needed to build on
Windows, but this is an easier fix (at least for me) than figuring
out how to get `cp` into the `PATH` in all cases, and judging
from the issue I’m not the only one who ran into this.

Fixes: nodejs/node#20272

PR-URL: nodejs/node#20296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit 2b85127)
alexeykuzmin pushed a commit to electron/node that referenced this issue May 4, 2018
@addaleax @alexeykuzmin
build: do not depend on cp in PATH
ea3592d 
Use gyp’s own copying mechanism instead.

It’s not really clear which UNIX utils exactly are needed to build on
Windows, but this is an easier fix (at least for me) than figuring
out how to get `cp` into the `PATH` in all cases, and judging
from the issue I’m not the only one who ran into this.

Fixes: nodejs/node#20272

PR-URL: nodejs/node#20296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit 2b85127)
MylesBorins pushed a commit that referenced this issue May 4, 2018
@addaleax @MylesBorins
build: do not depend on cp in PATH
2ce4b7c 
Use gyp’s own copying mechanism instead.

It’s not really clear which UNIX utils exactly are needed to build on
Windows, but this is an easier fix (at least for me) than figuring
out how to get `cp` into the `PATH` in all cases, and judging
from the issue I’m not the only one who ran into this.

Fixes: #20272

PR-URL: #20296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
alexeykuzmin pushed a commit to electron/node that referenced this issue May 24, 2018
@addaleax @alexeykuzmin
build: do not depend on cp in PATH
6e18355 
Use gyp’s own copying mechanism instead.

It’s not really clear which UNIX utils exactly are needed to build on
Windows, but this is an easier fix (at least for me) than figuring
out how to get `cp` into the `PATH` in all cases, and judging
from the issue I’m not the only one who ran into this.

Fixes: nodejs/node#20272

PR-URL: nodejs/node#20296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit 2b85127)
alexeykuzmin pushed a commit to electron/node that referenced this issue May 24, 2018
@addaleax @alexeykuzmin
build: do not depend on cp in PATH
8902e5a 
Use gyp’s own copying mechanism instead.

It’s not really clear which UNIX utils exactly are needed to build on
Windows, but this is an easier fix (at least for me) than figuring
out how to get `cp` into the `PATH` in all cases, and judging
from the issue I’m not the only one who ran into this.

Fixes: nodejs/node#20272

PR-URL: nodejs/node#20296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit 2b85127)
alexeykuzmin pushed a commit to electron/node that referenced this issue May 24, 2018
@addaleax @alexeykuzmin
build: do not depend on cp in PATH
320f354 
Use gyp’s own copying mechanism instead.

It’s not really clear which UNIX utils exactly are needed to build on
Windows, but this is an easier fix (at least for me) than figuring
out how to get `cp` into the `PATH` in all cases, and judging
from the issue I’m not the only one who ran into this.

Fixes: nodejs/node#20272

PR-URL: nodejs/node#20296
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
(cherry picked from commit 2b85127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: do not depend on cp in PATH addaleax/node
3 participants
@fs-eire @vsemozhetbyt @Hackzzila