stream: don't emit 'finish' after 'error'

Backport-PR-URL: #32372 PR-URL: #32275 Refs: #28710 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: #32372
nodejs · Mar 24, 2020 · 531d495 · 531d495
1 parent 0e291aa
commit 531d495
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js
@@ -647,6 +647,8 @@ function finishMaybe(stream, state) {
   if (need) {
     prefinish(stream, state);
     if (state.pendingcb === 0) {
+      if (state.errorEmitted)
+        return;
       state.finished = true;
       stream.emit('finish');
 

diff --git a/test/parallel/test-stream-writable-write-writev-finish.js b/test/parallel/test-stream-writable-write-writev-finish.js
@@ -132,6 +132,7 @@ const stream = require('stream');
     process.nextTick(cb);
   };
   w.on('error', common.mustCall());
+  w.on('finish', common.mustNotCall());
   w.on('prefinish', () => {
     w.write("shouldn't write in prefinish listener");
   });