Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: don't emit 'finish' after 'error' #32275

Closed
wants to merge 2 commits into from
Closed

stream: don't emit 'finish' after 'error' #32275

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 14, 2020

An edge case could emit 'finish' after 'error'.

Refs: #28710

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Mar 14, 2020
@ronag ronag requested review from mcollina and lpinca March 14, 2020 23:51
@ronag ronag force-pushed the stream-error-finish branch 2 times, most recently from 7999e19 to 96e82ca Compare March 14, 2020 23:59
@ronag ronag force-pushed the stream-error-finish branch from 96e82ca to 48e7a2e Compare March 15, 2020 00:00
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29837/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29846/

jasnell
jasnell reviewed Mar 16, 2020
View reviewed changes
lib/_stream_writable.js Outdated Show resolved Hide resolved
@ronag @jasnell
Update lib/_stream_writable.js
271f119 
Co-Authored-By: James M Snell <jasnell@gmail.com>
@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 16, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29868/

@ronag
Copy link
Member Author

ronag commented Mar 17, 2020

Landed in 9b20b5d

@ronag ronag closed this Mar 17, 2020
ronag added a commit that referenced this pull request Mar 17, 2020
@ronag
stream: don't emit 'finish' after 'error'
9b20b5d 
PR-URL: #32275
Refs: #28710
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

@ronag this doesn't land cleanly on v13.x, should it be backported?

@ronag ronag mentioned this pull request Mar 19, 2020
Closed
4 tasks
ronag added a commit to nxtedition/node that referenced this pull request Mar 19, 2020
@ronag
stream: don't emit 'finish' after 'error'
29d7863 
PR-URL: nodejs#32275
Refs: nodejs#28710
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: nodejs#32372
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@ronag @MylesBorins
stream: don't emit 'finish' after 'error'
531d495 
Backport-PR-URL: #32372
PR-URL: #32275
Refs: #28710
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: #32372
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@ronag @MylesBorins
stream: don't emit 'finish' after 'error'
23ba088 
Backport-PR-URL: #32372
PR-URL: #32275
Refs: #28710
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: #32372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ronag @nodejs-github-bot @MylesBorins @jasnell @lpinca @targos