Skip to content

Commit

Permalink
test: changed var to const, added strict equal checks
Browse files Browse the repository at this point in the history
Changed var to const where appropriate. Substituted
assert.strictEqual for assert.equal for better type checks.

PR-URL: #8762
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
llkats authored and Fishrock123 committed Oct 11, 2016
1 parent 81ed50c commit 6ba8aa9
Showing 1 changed file with 19 additions and 14 deletions.
33 changes: 19 additions & 14 deletions test/parallel/test-fs-read-stream-fd-leak.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
'use strict';

var common = require('../common');
var assert = require('assert');
var fs = require('fs');
var path = require('path');
const common = require('../common');
const assert = require('assert');
const fs = require('fs');
const path = require('path');

var openCount = 0;
var _fsopen = fs.open;
var _fsclose = fs.close;
const _fsopen = fs.open;
const _fsclose = fs.close;

var loopCount = 50;
var totalCheck = 50;
var emptyTxt = path.join(common.fixturesDir, 'empty.txt');
const loopCount = 50;
const totalCheck = 50;
const emptyTxt = path.join(common.fixturesDir, 'empty.txt');

fs.open = function() {
openCount++;
Expand All @@ -29,20 +29,25 @@ function testLeak(endFn, callback) {
var i = 0;
var check = 0;

var checkFunction = function() {
if (openCount != 0 && check < totalCheck) {
const checkFunction = function() {
if (openCount !== 0 && check < totalCheck) {
check++;
setTimeout(checkFunction, 100);
return;
}
assert.equal(0, openCount, 'no leaked file descriptors using ' +
endFn + '() (got ' + openCount + ')');

assert.strictEqual(
0,
openCount,
`no leaked file descriptors using ${endFn}() (got ${openCount})`
);

openCount = 0;
callback && setTimeout(callback, 100);
};

setInterval(function() {
var s = fs.createReadStream(emptyTxt);
const s = fs.createReadStream(emptyTxt);
s[endFn]();

if (++i === loopCount) {
Expand Down

0 comments on commit 6ba8aa9

Please sign in to comment.