changed var to const, added strict equality checks #8762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llkats
force-pushed
the
nodetodo-contrib
branch
from
f8c67e8
to
7e4c1b3
Compare
addaleax
reviewed
Sep 24, 2016
| check++; | ||
| setTimeout(checkFunction, 100); | ||
| return; | ||
| } | ||
| assert.equal(0, openCount, 'no leaked file descriptors using ' + | ||
| assert.strictEqual(0, openCount, 'no leaked file descriptors using ' + | ||
| endFn + '() (got ' + openCount + ')'); |
There was a problem hiding this comment.
Could you try to indent the second line here so that the arguments line up again?
There was a problem hiding this comment.
Oh, and just a suggestion, but maybe this would be better using a template string here? (If you agree that that might be more readable, that is.)
There was a problem hiding this comment.
Template string was a great idea. I've followed up with a commit - how do you like the look of it?
|
LGTM with @addaleax's comments and if CI has no surprises |
|
LGTM 🎉🎉🎉 |
MylesBorins
approved these changes
Sep 24, 2016
Changed var to const where appropriate. Substituted assert.strictEqual for assert.equal for better type checks.
llkats
force-pushed
the
nodetodo-contrib
branch
from
878f9b7
to
72e2def
Compare
|
@thealphanerd squasht! |
cjihrig
approved these changes
Sep 25, 2016
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Sep 26, 2016
Changed var to const where appropriate. Substituted assert.strictEqual for assert.equal for better type checks. PR-URL: #8762 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 52b6cfb |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
Changed var to const where appropriate. Substituted assert.strictEqual for assert.equal for better type checks. PR-URL: #8762 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Changed var to const where appropriate. Substituted assert.strictEqual for assert.equal for better type checks. PR-URL: #8762 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test fs
Description of change
Changed var to const where appropriate. Substituted
assert.strictEqual for assert.equal for better type checks.