Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Set the `SIGUSR2` handler before spawning the child process to make sure the signal is always handled. Fixes: #7767 PR-URL: #7854 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
93ac2ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#7767 is a 404
93ac2ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@targos that looks like a Github issue (bug?) then… if the issue didn’t exist, GH wouldn’t convert #7767 into a link. Also, the title text for the link is “Issue title is private”, which does not really make sense to me?
93ac2ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I see. Here is the explanation: isaacs/github#579 (comment)
93ac2ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. Yeah. @Trott’s Github account is gone…
93ac2ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if anyone will be able to see this, but GitHub thinks I'm a robot (probably because of tooling used to extract CTC agenda from issues, attn @rvagg). I can still see #7767 but everyone else apparently gets a 404. Presumably, it will be restored when my account has been restored. I've contacted GitHub support.
93ac2ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, looks good again, @Trott and #7767 and everything else seems back (I didn’t get a notification for @Trott’s comment here, so maybe it’s best to @mention @rvagg again).
93ac2ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Yes, they reinstated me speedily, thankfully.)
93ac2ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha wut??? oh man, I can't believe how much drama that tool has caused you @Trott. Maybe you should remove the token, get rid of
~/Library/Application Support/iojs-tools/
and runnode-meeting-agenda
again to refresh it. Sorry .. I wish I could explain how this has been so bad.93ac2ea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvagg I asked GitHub support if there was something specific I could/should do to prevent this from happening again. They indicated the problem was on their side so it's entirely possible that the tool is blameless.