Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-vm-sigint #7767

Closed
Trott opened this issue Jul 16, 2016 · 5 comments
Closed

Investigate flaky test-vm-sigint #7767

Trott opened this issue Jul 16, 2016 · 5 comments
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.

Comments

@Trott
Copy link
Member

Trott commented Jul 16, 2016

From time to time, test-vm-sigint.js fails on CI with no indication of what went wrong.

https://ci.nodejs.org/job/node-test-commit-linux/4202/nodes=centos5-32/console:

not ok 1066 parallel/test-vm-sigint
  ---
  duration_ms: 0.348

It's not timing out, but there's no assertion error either. It's just exiting with a bad code, I think?

/cc @addaleax
@Trott Trott added vm Issues and PRs related to the vm subsystem. test Issues and PRs related to the tests. labels Jul 16, 2016
@addaleax
Copy link
Member

fwiw, after you pinged me the first time on it, I ran the test with --repeat=100000 and it came back clean for me… any tips on how to get closer to the CI environment?

@addaleax
Copy link
Member

Also… would segfaults or similar conditions present that way in the CI output?

@Trott
Copy link
Member Author

Trott commented Jul 16, 2016

Alas, not sure how to repeat it. I think segfaults would show up in the CI output, but... uh... /cc @nodejs/build on both questions, I guess. @nodejs/testing too?

@santigimeno santigimeno mentioned this issue Jul 23, 2016
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Jul 30, 2016

Another today, this time on 64-bit CentOS 5.

https://ci.nodejs.org/job/node-test-commit-linux/4390/nodes=centos5-64/console:

not ok 1071 parallel/test-vm-sigint
  ---
  duration_ms: 0.161

@Trott
Copy link
Member Author

Trott commented Aug 2, 2016

Now that there's code added to print the signal, it fails like this:

not ok 1072 parallel/test-vm-sigint
# CRASHED (Signal: 12)

https://ci.nodejs.org/job/node-test-commit-linux/4427/nodes=centos5-64/console

/cc @santigimeno

cjihrig pushed a commit that referenced this issue Aug 10, 2016
@santigimeno @cjihrig
test: fix test-vm-sigint flakiness
d94063a 
Set the `SIGUSR2` handler before spawning the child process to make sure
the signal is always handled.

Fixes: #7767
PR-URL: #7854
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trott @addaleax