lib: use null-prototype objects for property descriptors

PR-URL: #43473 Reviewed-By: Darshan Sen <raisinten@gmail.com>
nodejs · Jul 31, 2022 · aab5adb · aab5adb
1 parent a97d0ba
commit aab5adb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -132,11 +132,13 @@ addBufferPrototypeMethods(Buffer.prototype);
 
 const constants = ObjectDefineProperties({}, {
   MAX_LENGTH: {
+    __proto__: null,
     value: kMaxLength,
     writable: false,
     enumerable: true
   },
   MAX_STRING_LENGTH: {
+    __proto__: null,
     value: kStringMaxLength,
     writable: false,
     enumerable: true

diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -1181,9 +1181,9 @@ function createTeeReadableStream(start, pull, cancel) {
       setupReadableStreamDefaultControllerFromSource(
         this,
         ObjectCreate(null, {
-          start: { value: start },
-          pull: { value: pull },
-          cancel: { value: cancel }
+          start: { __proto__: null, value: start },
+          pull: { __proto__: null, value: pull },
+          cancel: { __proto__: null, value: cancel }
         }),
         1,
         () => 1);

diff --git a/lib/internal/webstreams/util.js b/lib/internal/webstreams/util.js
@@ -49,11 +49,13 @@ const kType = Symbol('kType');
 
 const AsyncIterator = ObjectCreate(AsyncIteratorPrototype, {
   next: {
+    __proto__: null,
     configurable: true,
     enumerable: true,
     writable: true,
   },
   return: {
+    __proto__: null,
     configurable: true,
     enumerable: true,
     writable: true,