Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: use null-prototype objects for property descriptors #43473

Merged
merged 1 commit into from
Jun 27, 2022
Merged

lib: use null-prototype objects for property descriptors #43473

merged 1 commit into from
Jun 27, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 18, 2022

Left over from #43270 (lint rule fix coming in a follow up PR)

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Jun 18, 2022
@aduh95 aduh95 mentioned this pull request Jun 18, 2022
Merged
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 20, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44753/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 27, 2022
@nodejs-github-bot nodejs-github-bot merged commit bb30e2d into nodejs:main Jun 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in bb30e2d

@aduh95 aduh95 deleted the null-prototype-property-desc branch June 27, 2022 16:27
targos pushed a commit that referenced this pull request Jul 12, 2022
@aduh95 @targos
lib: use null-prototype objects for property descriptors
2233567 
PR-URL: #43473
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@aduh95 @targos
lib: use null-prototype objects for property descriptors
fc05822 
PR-URL: #43473
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95 @targos
lib: use null-prototype objects for property descriptors
aab5adb 
PR-URL: #43473
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95 @guangwong
lib: use null-prototype objects for property descriptors
1e39d3d 
PR-URL: nodejs/node#43473
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduh95 @nodejs-github-bot @RaisinTen