Skip to content

Commit

Permalink
crypto: fix performance regression
Browse files Browse the repository at this point in the history
e559842
made writable/readable computed with a legacy mode if the properties
are written to.

LazyTransform still unecessarily wrote to these properties causing a
performance regression.

Fixes: #31739

PR-URL: #31742
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
ronag authored and codebytere committed Mar 30, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 0b75790 commit b84fd94
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions lib/internal/streams/lazy_transform.js
Original file line number Diff line number Diff line change
@@ -19,8 +19,6 @@ module.exports = LazyTransform;

function LazyTransform(options) {
this._options = options;
this.writable = true;
this.readable = true;
}
ObjectSetPrototypeOf(LazyTransform.prototype, stream.Transform.prototype);
ObjectSetPrototypeOf(LazyTransform, stream.Transform);

0 comments on commit b84fd94

Please sign in to comment.