-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: fixes performance regression #31742
Conversation
6a36d5f
to
9a9f9d1
Compare
nodejs@e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: nodejs#31739
9a9f9d1
to
81e6995
Compare
It looks like some benchmark parameters were removed from the first Benchmark CI. Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/526/console While it seems this mostly fixes the performance issues, I noticed there are some instances of regressions for some reason:
It would be nice if we could figure out the cause of them. I've re-ran the benchmarks to verify and the results are the same. |
That was by accident. Resolved since then. |
Aren't those differences mostly within margin of error? |
Not as far as I understand it. Perhaps @AndreasMadsen can give a more definitive answer though. |
@Trott: What does "yellow" ci mean? Doesn't seem to re-run on "resume build"? |
@ronag Yellow means that the only failures were known (i.e. almost always unrelated) flaky tests. I think they should re-run on “resume build”, but landing with a yellow CI is generally okay. |
@ronag They are not, no – the high level of confidence means that it’s safe to assume that they are real and caused by the changes here. Whether they are acceptable as a regression is another question, though. (I’m removing author-ready because of that, but if you’d like to go ahead and land this then I’m personally okay with that.) |
I am personally in favor of landing with the changes - including the regressions. Mostly because the regressions aren't big and the benchmarks are very positive. |
Landed in 9cbf6af |
e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: #31739 PR-URL: #31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: #31739 PR-URL: #31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: #31739 PR-URL: #31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: #31739 PR-URL: #31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
e559842 made writable/readable computed with a legacy mode if the properties are written to. LazyTransform still unecessarily wrote to these properties causing a performance regression. Fixes: #31739 PR-URL: #31742 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
e559842
made writable/readable computed with a legacy mode if the properties
are written to.
LazyTransform still unecessarily wrote to these properties causing a performance
regression.
Fixes: #31739
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes