Skip to content

Commit

Permalink
src: remove obsolete NOLINT comments
Browse files Browse the repository at this point in the history
Obsoleted by the recent cpplint upgrade.

PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
  • Loading branch information
bnoordhuis committed Jun 28, 2016
1 parent 9a6439a commit f8d3f6f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions src/node_buffer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1248,9 +1248,7 @@ void Swap64(const FunctionCallbackInfo<Value>& args) {
std::swap(ts_obj_data[i], ts_obj_data[i + 7]);
std::swap(ts_obj_data[i + 1], ts_obj_data[i + 6]);
std::swap(ts_obj_data[i + 2], ts_obj_data[i + 5]);
// NOLINT added because current cpplint.py is old and doesn't know that
// std::swap() now lives in <utility> instead of <algorithm>.
std::swap(ts_obj_data[i + 3], ts_obj_data[i + 4]); // NOLINT
std::swap(ts_obj_data[i + 3], ts_obj_data[i + 4]);
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/stream_base.h
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ class StreamBase : public StreamResource {
const v8::PropertyCallbackInfo<v8::Value>& args);

template <class Base,
int (StreamBase::*Method)( // NOLINT(whitespace/parens)
int (StreamBase::*Method)(
const v8::FunctionCallbackInfo<v8::Value>& args)>
static void JSMethod(const v8::FunctionCallbackInfo<v8::Value>& args);

Expand Down
2 changes: 1 addition & 1 deletion src/string_search.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class StringSearch : private StringSearchBase {
}

private:
typedef size_t (*SearchFunction)( // NOLINT - it's not a cast!
typedef size_t (*SearchFunction)(
StringSearch<Char>*,
Vector<const Char>,
size_t);
Expand Down

0 comments on commit f8d3f6f

Please sign in to comment.