src: use HandleScope in StreamReq::Done()

Fixes: #38707 PR-URL: #38720 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs · May 21, 2021 · fcdb1db · fcdb1db
1 parent 13ec317
commit fcdb1db
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/stream_base-inl.h b/src/stream_base-inl.h
@@ -279,6 +279,7 @@ void StreamReq::Done(int status, const char* error_str) {
   AsyncWrap* async_wrap = GetAsyncWrap();
   Environment* env = async_wrap->env();
   if (error_str != nullptr) {
+    v8::HandleScope handle_scope(env->isolate());
     async_wrap->object()->Set(env->context(),
                               env->error_string(),
                               OneByteString(env->isolate(), error_str))

diff --git a/test/parallel/test-https-agent-unref-socket.js b/test/parallel/test-https-agent-unref-socket.js
@@ -0,0 +1,13 @@
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const https = require('https');
+
+const request = https.get('https://example.com');
+
+request.on('socket', (socket) => {
+  socket.unref();
+});