Skip to content

src: use HandleScope in StreamReq::Done() #38720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

src: use HandleScope in StreamReq::Done() #38720

wants to merge 2 commits into from

Conversation

@RaisinTen
Copy link
Member

@RaisinTen RaisinTen commented May 18, 2021

Fixes: #38707

@nodejs-github-bot

This comment has been minimized.

Sign in to view
Ayase-252
Ayase-252 reviewed May 18, 2021
View reviewed changes
@RaisinTen @Ayase-252
Apply suggestions from code review
d89dbd1 
Co-authored-by: Qingyu Deng <i@ayase-lab.com>
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 19, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 21, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38254/ 💚

@jasnell
Copy link
Member

jasnell commented May 21, 2021

Landed in fcdb1db

@jasnell jasnell closed this May 21, 2021
jasnell pushed a commit that referenced this pull request May 21, 2021
@RaisinTen @jasnell
src: use HandleScope in StreamReq::Done()
fcdb1db 
Fixes: #38707

PR-URL: #38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@RaisinTen RaisinTen deleted the src/use-HandleScope-in-StreamReq.Done branch May 22, 2021 14:35
danielleadams pushed a commit that referenced this pull request May 31, 2021
@RaisinTen @danielleadams
src: use HandleScope in StreamReq::Done()
4e33532 
Fixes: #38707

PR-URL: #38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request May 31, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@RaisinTen @richardlau
src: use HandleScope in StreamReq::Done()
c254186 
Fixes: #38707

PR-URL: #38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@RaisinTen @richardlau
src: use HandleScope in StreamReq::Done()
ee66cfc 
Fixes: #38707

PR-URL: #38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@RaisinTen @richardlau
src: use HandleScope in StreamReq::Done()
2d32031 
Fixes: #38707

PR-URL: #38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@richardlau richardlau mentioned this pull request Jul 20, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@RaisinTen @foxxyz
src: use HandleScope in StreamReq::Done()
efba51f 
Fixes: nodejs#38707

PR-URL: nodejs#38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ayase-252 Ayase-252 Ayase-252 left review comments

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unref a socket raise v8 error

5 participants

@RaisinTen @nodejs-github-bot @jasnell @addaleax @Ayase-252